Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update method names in DefaultSkinHelper to reflect new return type #3681

Merged
merged 1 commit into from
Oct 4, 2023
Merged

Update method names in DefaultSkinHelper to reflect new return type #3681

merged 1 commit into from
Oct 4, 2023

Conversation

enjarai
Copy link
Contributor

@enjarai enjarai commented Oct 4, 2023 •
edited
Loading

I noticed that, as of 1.20.2, the names of two of the getTexture methods in DefaultSkinHelper no longer make sense given the changed return type of those methods. They now return an instance of SkinTextures, instead of an Identifier, so naming them getSkinTextures seems more appropriate.

@Shnupbups Shnupbups merged commit 36373c6 into FabricMC:1.20.2 Oct 4, 2023
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Shnupbups Shnupbups Shnupbups approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@enjarai @Shnupbups